Conversation
added 10 commits
October 16, 2020 17:23
charliesantos
approved these changes
Oct 20, 2020
jon-price-snke
added a commit
to visiontree-software/vtoc-fasttrack-video
that referenced
this pull request
Oct 21, 2020
* upstream/master: Update firebase (twilio#335) Revert "Increase throttle interval in ToggleVideoButton component" Increase throttle interval in ToggleVideoButton component Ahoyapps 771 store user preferences (twilio#333) Fix cypress flakiness (twilio#332) Bump @hapi/hoek from 8.5.0 to 8.5.1 (twilio#300) Update readme section about pricing (twilio#318) Implement Go Room Type Support and a Design Refresh (twilio#316) Add room type section to readme [skip ci] (twilio#306) Update twilio-video to version 2.7.2 (twilio#304)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR updates Cypress tests so that they pass more reliably. The assertions on the AudioIndicatorComponent were redone to better use Cypress' retry-ability feature.
Cypress was also upgraded to version 5 to take advantage of the Test Retries feature (which is different than the 'retry-ability'. Test timeout was also increased.
Burndown
Before review
npm testBefore merge